@

R1: Umbau auf Multi-Projekt-Struktur (Vorbild PolytraderSharp) Kurskorrektur: Vorbild ist PolytraderSharp (C#), nicht die veraltete Python-Version. Reiner Strukturumbau, Verhalten unveraendert. - src/IBKRTrader.Core (classlib): Core-Code + UI-Contract (ModuleFormBase, WindowManager) - src/IBKRTrader.Modules.CongressTrading (classlib, referenziert nur Core) - Root: IBKRTrader.App (WinExe) referenziert Core + Modul - tests/IBKRTrader.Tests: Referenzen auf Core + Modul - Neue .slnx; ungenutztes HtmlAgilityPack entfernt - docs/ARCHITECTURE.md: korrigierter Ziel-Stand + R-Phasenplan - Build + 38/38 Tests gruen; App startet Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> @
2026-07-27 20:26:25 +02:00
parent 2ad4b55db1
commit c20538c8d8
61 changed files with 171 additions and 129 deletions
@@ -0,0 +1,57 @@
+using FluentAssertions;
+using IBKRTrader.Core.Logging;
+using IBKRTrader.Modules.CongressTrading.Scraper;
+
+namespace IBKRTrader.Tests.Modules;
+
+[Trait("cat", "unit")]
+public class CapitolTradesScraperTests
+{
+    private static string LoadFixture()
+    {
+        var path = Path.Combine(AppContext.BaseDirectory, "Fixtures", "ct_raw.html");
+        File.Exists(path).Should().BeTrue($"Fixture fehlt: {path}");
+        return File.ReadAllText(path);
+    }
+
+    [Fact]
+    public void ParseTradesFromHtml_ExtractsTradesFromRscStream()
+    {
+        var scraper = new CapitolTradesScraper(new LoggingService());
+
+        var (trades, memberIds) = scraper.ParseTradesFromHtml(LoadFixture());
+
+        trades.Should().NotBeEmpty("die Fixture enthält einen RSC-Datenstrom mit Trades");
+        memberIds.Should().NotBeEmpty();
+
+        var first = trades[0];
+        first.TradeId.Should().NotBeNullOrWhiteSpace();
+        first.TradeType.Should().NotBeNullOrWhiteSpace();
+    }
+
+    [Fact]
+    public void ParseTradesFromHtml_MapsMemberSnapshotConsistently()
+    {
+        var scraper = new CapitolTradesScraper(new LoggingService());
+
+        var (trades, memberIds) = scraper.ParseTradesFromHtml(LoadFixture());
+
+        // Jeder Member-Snapshot muss eine BioId haben, die auch im MemberBioIds-Set liegt.
+        foreach (var trade in trades.Where(t => t.MemberSnapshot is not null))
+        {
+            trade.MemberSnapshot!.BioId.Should().NotBeNullOrWhiteSpace();
+            memberIds.Should().Contain(trade.MemberBioId);
+        }
+    }
+
+    [Fact]
+    public void ParseTradesFromHtml_EmptyHtml_ReturnsNoTrades()
+    {
+        var scraper = new CapitolTradesScraper(new LoggingService());
+
+        var (trades, memberIds) = scraper.ParseTradesFromHtml("<html><body>nichts</body></html>");
+
+        trades.Should().BeEmpty();
+        memberIds.Should().BeEmpty();
+    }
+}
@@ -0,0 +1,65 @@
+using FluentAssertions;
+using IBKRTrader.Core.Database;
+using IBKRTrader.Core.Logging;
+using IBKRTrader.Core.Settings;
+using IBKRTrader.Core.Workers;
+using IBKRTrader.Modules.CongressTrading;
+using IBKRTrader.Modules.CongressTrading.Database;
+using IBKRTrader.Modules.CongressTrading.Scraper;
+using IBKRTrader.Modules.CongressTrading.Workers;
+using IBKRTrader.UI;
+using Microsoft.Extensions.DependencyInjection;
+
+namespace IBKRTrader.Tests.Modules;
+
+[Trait("cat", "unit")]
+public class CongressTradingModuleTests
+{
+    [Fact]
+    public void Metadata_IsAsExpected()
+    {
+        var module = new CongressTradingModule();
+
+        module.Key.Should().Be("CT");
+        module.DisplayName.Should().NotBeNullOrWhiteSpace();
+        module.Version.Should().Be("1.0.0");
+    }
+
+    [Fact]
+    public void RegisterServices_RegistersAllModuleServices()
+    {
+        var services = new ServiceCollection();
+
+        new CongressTradingModule().RegisterServices(services);
+
+        var registered = services.Select(d => d.ServiceType).ToList();
+        registered.Should().Contain(new[]
+        {
+            typeof(CongressMigrations),
+            typeof(CongressRepository),
+            typeof(CapitolTradesScraper),
+            typeof(CongressHistoryImportWorker),
+            typeof(CongressScrapeWorker),
+        });
+    }
+
+    [Fact]
+    public void CreateWindow_ReturnsModuleForm()
+    {
+        // Minimaler DI-Container mit allen von CreateWindow benötigten Abhängigkeiten.
+        var services = new ServiceCollection();
+        services.AddSingleton<SettingsService>();
+        services.AddSingleton<LoggingService>();
+        services.AddSingleton<DatabaseService>();
+        services.AddSingleton<IEnumerable<IWorker>>(_ => Array.Empty<IWorker>());
+        services.AddSingleton<WorkerEngine>();
+        var module = new CongressTradingModule();
+        module.RegisterServices(services);
+
+        using var provider = services.BuildServiceProvider();
+        using var form = module.CreateWindow(provider);
+
+        form.Should().BeAssignableTo<ModuleFormBase>();
+        ((ModuleFormBase)form).ModuleKey.Should().Be("CT");
+    }
+}
@@ -0,0 +1,49 @@
+using FluentAssertions;
+using IBKRTrader.Core.Modules;
+using IBKRTrader.Core.Workers;
+using Microsoft.Extensions.DependencyInjection;
+
+namespace IBKRTrader.Tests.Modules;
+
+[Trait("cat", "unit")]
+public class ModuleRegistryTests
+{
+    private sealed class FakeModule(string key) : IModule
+    {
+        public string Key         => key;
+        public string DisplayName => $"Fake {key}";
+        public string Description => "test";
+        public string Version     => "0.0.1";
+
+        public void RegisterServices(IServiceCollection services) { }
+        public Task InitializeAsync(IServiceProvider provider) => Task.CompletedTask;
+        public IEnumerable<IWorker> GetWorkers(IServiceProvider provider) => [];
+        public Form CreateWindow(IServiceProvider provider) => new();
+    }
+
+    [Fact]
+    public void Modules_PreservesRegistrationOrder()
+    {
+        var registry = new ModuleRegistry([new FakeModule("A"), new FakeModule("B")]);
+
+        registry.Modules.Select(m => m.Key).Should().ContainInOrder("A", "B");
+    }
+
+    [Fact]
+    public void Find_IsCaseInsensitive()
+    {
+        var registry = new ModuleRegistry([new FakeModule("CT")]);
+
+        registry.Find("ct").Should().NotBeNull();
+        registry.Find("CT").Should().NotBeNull();
+        registry.Find("XX").Should().BeNull();
+    }
+
+    [Fact]
+    public void Ctor_NullModules_Throws()
+    {
+        var act = () => new ModuleRegistry(null!);
+
+        act.Should().Throw<ArgumentNullException>();
+    }
+}