Fix: Implement FixPlan part A9, A10, B

This commit is contained in:
Richard
2026-07-10 12:04:27 +02:00
parent 44f48284a2
commit 1787422243
28 changed files with 1025 additions and 79 deletions
@@ -31,6 +31,8 @@ public static class ApiConfiguration
app.MapAlertEndpoints();
app.MapMarketEndpoints();
app.MapJobEndpoints();
app.MapDevEndpoints();
app.MapWatchlistEndpoints();
// Health check
app.MapGet("/api/health", () => Results.Ok(new { Status = "OK", Timestamp = DateTime.UtcNow }));
@@ -0,0 +1,97 @@
using Microsoft.AspNetCore.Builder;
using Microsoft.AspNetCore.Http;
using Microsoft.AspNetCore.Routing;
using Microsoft.EntityFrameworkCore;
using Microsoft.Extensions.DependencyInjection;
using Predictalytics.Domain.Entities;
using Predictalytics.Domain.Interfaces;
using Predictalytics.Infrastructure.Data;
namespace Predictalytics.Api.Endpoints;
public static class DevEndpoints
{
public static void MapDevEndpoints(this IEndpointRouteBuilder routes)
{
var group = routes.MapGroup("/api/dev");
group.MapGet("/verify-positions/{traderId:int}", async (int traderId, AppDbContext db, IEnumerable<IPlatformProvider> providers, CancellationToken ct) =>
{
var trader = await db.Traders.FindAsync(new object[] { traderId }, ct);
if (trader == null) return Results.NotFound("Trader not found");
var provider = providers.FirstOrDefault(p => p.Platform == trader.Platform && p.IsImplemented);
if (provider == null) return Results.BadRequest("Platform provider not found");
var apiPositions = await provider.GetTraderPositionsAsync(trader.PlatformUserId, ct);
var dbPositions = await db.TraderPositions
.Include(p => p.MarketOutcome)
.Where(p => p.TraderId == traderId && p.SharesHeld > 0)
.ToListAsync(ct);
var apiPosDict = apiPositions.ToDictionary(p => p.AssetId ?? "");
var dbPosDict = dbPositions.ToDictionary(p => p.MarketOutcome?.TokenId ?? "");
var mismatches = new List<object>();
// Check DB -> API
foreach (var kvp in dbPosDict)
{
if (string.IsNullOrEmpty(kvp.Key)) continue;
if (!apiPosDict.TryGetValue(kvp.Key, out var apiPos))
{
mismatches.Add(new { Token = kvp.Key, DB = kvp.Value.SharesHeld, API = 0, Reason = "Missing in API" });
}
else if (Math.Abs(kvp.Value.SharesHeld - apiPos.Size) > 0.01m)
{
mismatches.Add(new { Token = kvp.Key, DB = kvp.Value.SharesHeld, API = apiPos.Size, Reason = "Size mismatch" });
}
}
// Check API -> DB
foreach (var kvp in apiPosDict)
{
if (string.IsNullOrEmpty(kvp.Key)) continue;
if (!dbPosDict.ContainsKey(kvp.Key))
{
mismatches.Add(new { Token = kvp.Key, DB = 0, API = kvp.Value.Size, Reason = "Missing in DB" });
}
}
return Results.Ok(new
{
TraderId = traderId,
Mismatches = mismatches,
Match = mismatches.Count == 0,
DbPositionsCount = dbPosDict.Count,
ApiPositionsCount = apiPosDict.Count
});
});
group.MapPost("/repair-db", async (AppDbContext db, CancellationToken ct) =>
{
await db.Database.ExecuteSqlRawAsync(@"
-- 1. Fake PnL Trades löschen
DELETE FROM Trades WHERE Type = 4 AND Payout = 0 AND Size = 0;
-- 2. Positionen löschen, da sie durch Sync neu aufgebaut werden
DELETE FROM TraderPositions;
-- 3. Sync State von Tradern zurücksetzen (DeepResync forcieren)
UPDATE Traders SET
IsInitialImportComplete = 0,
LastTradesUpdatedAt = NULL,
LastPositionsUpdatedAt = NULL,
TotalPnl = 0,
WinRate = 0,
TotalTrades = 0,
EstimatedBankroll = 0;
-- 4. Jobs abbrechen
UPDATE Jobs SET Status = 5 WHERE Status IN (1, 2);
", ct);
return Results.Ok("DB repaired. DeepResync needed.");
});
}
}
@@ -54,6 +54,38 @@ public static class JobEndpoints
return Results.Ok(job.Id);
});
group.MapPost("/deep-resync/{traderId:int}", async (int traderId, IJobRepository repo, CancellationToken ct) =>
{
var job = new BackgroundJob
{
JobType = JobType.DeepResync,
Status = JobStatus.Pending,
TraderId = traderId
};
await repo.AddAsync(job, ct);
return Results.Ok(job.Id);
});
group.MapPost("/deep-resync-pruned", async (Predictalytics.Infrastructure.Data.AppDbContext db, IJobRepository repo, CancellationToken ct) =>
{
var traderIds = await Microsoft.EntityFrameworkCore.EntityFrameworkQueryableExtensions.ToListAsync(
db.TraderPositions.Where(tp => tp.IsHistoryPruned).Select(tp => tp.TraderId).Distinct(), ct);
int count = 0;
foreach (var tid in traderIds)
{
var job = new BackgroundJob
{
JobType = JobType.DeepResync,
Status = JobStatus.Pending,
TraderId = tid
};
await repo.AddAsync(job, ct);
count++;
}
return Results.Ok(new { Count = count });
});
group.MapPost("/analyze-backlog", async (int? take, IJobRepository repo, Predictalytics.Infrastructure.Data.AppDbContext db, CancellationToken ct) =>
{
int batchSize = take ?? 50;
@@ -35,18 +35,7 @@ public static class TraderEndpoints
await svc.SetManualOverrideAsync(id, score, ct);
return Results.Ok();
});
group.MapPost("/{id:int}/refresh", async (int id, IAnalyticsService svc, CancellationToken ct) =>
{
await svc.TriggerTradeSyncAsync(id, ct);
return Results.Ok();
});
group.MapPost("/{id:int}/force-analyze", async (int id, IAnalyticsService svc, CancellationToken ct) =>
{
await svc.ForceAnalyzeTraderAsync(id, ct);
return Results.Ok();
});
group.MapPost("/{id:int}/watchlist", async (int id, WatchlistService svc, CancellationToken ct) =>
{
@@ -0,0 +1,29 @@
using Microsoft.AspNetCore.Mvc;
using Predictalytics.Application.Services;
namespace Predictalytics.Api.Endpoints;
public static class WatchlistEndpoints
{
public static void MapWatchlistEndpoints(this IEndpointRouteBuilder routes)
{
var group = routes.MapGroup("/api/watchlist").WithTags("Watchlist");
group.MapGet("/", async (WatchlistService svc, CancellationToken ct) =>
{
var list = await svc.GetAllAsync(ct);
return Results.Ok(list.Select(w => new
{
w.TraderId,
w.Trader.DisplayName,
w.Trader.PlatformUserId,
w.Trader.TotalPnl,
w.Trader.WinRate,
CopytradingScore = w.Trader.CurrentScore?.CombinedScore ?? 0,
w.Label,
w.Notes,
CreatedAt = w.AddedAt
}));
});
}
}
+33
View File
@@ -26,6 +26,10 @@
<svg width="20" height="20" viewBox="0 0 24 24" fill="none" stroke="currentColor" stroke-width="2"><path d="M17 21v-2a4 4 0 0 0-4-4H5a4 4 0 0 0-4 4v2"/><circle cx="9" cy="7" r="4"/><path d="M23 21v-2a4 4 0 0 0-3-3.87"/><path d="M16 3.13a4 4 0 0 1 0 7.75"/></svg>
<span>Traders</span>
</a>
<a href="#" class="nav-item" data-page="watchlist">
<svg width="20" height="20" viewBox="0 0 24 24" fill="none" stroke="currentColor" stroke-width="2"><polygon points="12 2 15.09 8.26 22 9.27 17 14.14 18.18 21.02 12 17.77 5.82 21.02 7 14.14 2 9.27 8.91 8.26 12 2"/></svg>
<span>Watchlist</span>
</a>
<a href="#" class="nav-item" data-page="markets">
<svg width="20" height="20" viewBox="0 0 24 24" fill="none" stroke="currentColor" stroke-width="2"><polyline points="22 12 18 12 15 21 9 3 6 12 2 12"/></svg>
<span>Markets</span>
@@ -187,6 +191,32 @@
</div>
</section>
<!-- Watchlist Page -->
<section class="page" id="page-watchlist">
<div style="display:flex; justify-content:space-between; align-items:center; margin-bottom:24px; flex-wrap:wrap; gap:12px;">
<h1 class="page-title" style="margin-bottom:0">Watchlist</h1>
</div>
<div class="card">
<div class="table-wrap">
<table class="data-table" id="watchlistTable">
<thead>
<tr>
<th>Trader</th>
<th>Platform</th>
<th>Score</th>
<th>Win Rate</th>
<th>PnL</th>
<th>Label</th>
<th>Added</th>
<th>Actions</th>
</tr>
</thead>
<tbody id="watchlistBody"></tbody>
</table>
</div>
</div>
</section>
<!-- Markets Page -->
<section class="page" id="page-markets">
<div style="display:flex; justify-content:space-between; align-items:center; margin-bottom:24px; flex-wrap:wrap; gap:12px;">
@@ -286,6 +316,9 @@
<button class="btn-sm btn-primary" id="btn-sync-trader">
⟱ Sync
</button>
<button class="btn-sm btn-outline" id="btn-deep-resync-trader" style="border-color:var(--pnl-negative); color:var(--pnl-negative);">
⟱ Deep Resync
</button>
<button class="btn-sm btn-primary" id="btn-analyze-trader">
⚙ Analyze
</button>
+62 -23
View File
@@ -27,6 +27,7 @@ document.querySelectorAll('.nav-item[data-page]').forEach(item => {
if (page === 'alerts') loadAlerts();
if (page === 'markets') loadMarkets();
if (page === 'jobs') loadJobs();
if (page === 'watchlist') loadWatchlist();
});
});
@@ -106,14 +107,7 @@ async function manualAddTrader() {
}
}
async function manualUpdateTrader(id) {
const res = await fetch(`/api/traders/${id}/refresh`, { method: 'POST' });
if (res.ok) {
alert('Sync triggered manually. Data will update in a few minutes.');
} else {
alert('Failed to trigger sync.');
}
}
let currentPlatform = 'All';
let currentSort = 'default';
@@ -134,14 +128,16 @@ function refreshActivePage() {
if (activePage === 'page-dashboard') loadDashboard();
else if (activePage === 'page-traders') loadTraders();
else if (activePage === 'page-markets') loadMarkets();
else if (activePage === 'page-watchlist') loadWatchlist();
}
// ─── API Helpers ───
async function api(endpoint) {
async function api(endpoint, options = {}) {
try {
const res = await fetch(`${API_BASE}${endpoint}`);
const res = await fetch(`${API_BASE}${endpoint}`, options);
if (!res.ok) throw new Error(`HTTP ${res.status}`);
return await res.json();
const text = await res.text();
return text ? JSON.parse(text) : true;
} catch (err) {
console.error(`API Error [${endpoint}]:`, err);
return null;
@@ -349,6 +345,41 @@ async function loadTraders() {
`).join('');
}
async function loadWatchlist() {
const data = await api(`/api/watchlist`);
if (!data) return;
const tbody = document.getElementById('watchlistBody');
tbody.innerHTML = data.map(w => `
<tr>
<td class="trader-name">
<div class="avatar">${w.displayName.substring(0, 2).toUpperCase()}</div>
<div>
<strong>${w.displayName}</strong><br>
<span style="font-size:12px; color:var(--text-secondary)">${w.platformUserId.substring(0, 8)}...</span>
</div>
</td>
<td>${w.platform ?? 'Unknown'}</td>
<td>${Number(w.copytradingScore || 0).toFixed(1)}</td>
<td class="${w.winRate > 0.5 ? 'text-green' : 'text-red'}">${fmt.pct(w.winRate)}</td>
<td class="${w.totalPnl >= 0 ? 'text-green' : 'text-red'}">${fmt.pnl(w.totalPnl)}</td>
<td>${w.label || ''}</td>
<td>${new Date(w.createdAt).toLocaleDateString()}</td>
<td>
<button class="btn-sm" onclick="viewTrader(${w.traderId})">View</button>
<button class="btn-sm btn-outline-danger" onclick="removeFromWatchlist(${w.traderId})">Remove</button>
</td>
</tr>
`).join('') || '<tr><td colspan="8">Your watchlist is empty.</td></tr>';
}
async function removeFromWatchlist(id) {
if (confirm('Remove this trader from watchlist?')) {
await api(`/api/traders/${id}/watchlist`, { method: 'DELETE' });
loadWatchlist();
}
}
// ─── Alerts Page ───
async function loadAlerts() {
const data = await api('/api/alerts?count=50');
@@ -429,22 +460,21 @@ async function viewTrader(id) {
const syncBtn = document.getElementById('btn-sync-trader');
if (syncBtn) {
syncBtn.onclick = () => manualUpdateTrader(id);
syncBtn.onclick = () => queueHistorySync(id);
}
const deepSyncBtn = document.getElementById('btn-deep-resync-trader');
if (deepSyncBtn) {
deepSyncBtn.onclick = () => {
if (confirm("Are you sure? This will delete all compacted trades and reset positions, then fetch all historical trades via pagination.")) {
queueDeepResync(id);
}
};
}
const analyzeBtn = document.getElementById('btn-analyze-trader');
if (analyzeBtn) {
analyzeBtn.onclick = async () => {
analyzeBtn.disabled = true;
analyzeBtn.textContent = '...';
try {
await api(`/api/traders/${id}/force-analyze`, { method: 'POST' });
alert('Deep Analysis queued! Please wait a moment and then refresh.');
} finally {
analyzeBtn.disabled = false;
analyzeBtn.textContent = '⚙ Analyze';
}
};
analyzeBtn.onclick = () => queueTraderAnalysis(id);
}
const aiBtn = document.getElementById('btn-ai-analysis');
@@ -658,6 +688,15 @@ async function queueHistorySync(id) {
}
}
async function queueDeepResync(id) {
const res = await fetch(`/api/jobs/deep-resync/${id}`, { method: 'POST' });
if (res.ok) {
alert('Deep Resync job queued successfully.');
} else {
alert('Failed to queue deep resync.');
}
}
async function queueTraderAnalysis(id) {
const res = await fetch(`/api/jobs/analyze/${id}`, { method: 'POST' });
if (res.ok) {
@@ -654,4 +654,128 @@ public class PositionPnLEngineTests
Assert.Equal(0m, analytics.PnL24h);
}
}
// ═════════════════════════════════════════════════════════════════════════
// Invariant tests added 2026-07-10 (review round 5).
// Root cause found via live Gamma API: the response contains NO
// "resolution_outcome" and NO "resolved" field. Market.ResolutionOutcome is
// therefore ALWAYS NULL in our DB, and IsResolved is effectively just
// "closed". Winner detection must use the snapped outcomePrices (winner→1,
// loser→0, persisted in MarketOutcome.CurrentPrice) and/or
// "umaResolutionStatus". EXPECTED TO BE RED until fixed.
// ═════════════════════════════════════════════════════════════════════════
/// <summary>
/// Defect 11a: A resolved market whose ResolutionOutcome string is NULL
/// (which is ALL markets today) must still pay out winners. The winner is
/// identifiable by its snapped price (CurrentPrice ≈ 1). Booking payout 0
/// for every winner is what currently makes every trader show
/// WinRate 0% and negative PnL.
/// </summary>
[Fact]
public async Task RecalculateTraderPositionsAsync_ResolvedMarketWithoutResolutionOutcome_PaysWinnerViaSnappedPrice()
{
// Arrange
var dbName = Guid.NewGuid().ToString();
using (var db = CreateDbContext(dbName))
{
var trader = new Trader { Id = 1, PlatformUserId = "0x1", DisplayName = "Trader 1" };
var market = new Market
{
Id = 10, PlatformMarketId = 1L, Question = "Q?",
IsResolved = true,
ResolutionOutcome = null // ← reality: Gamma never delivers this field
};
// Snapped prices after resolution: this outcome won.
market.Outcomes.Add(new MarketOutcome { Id = 100, MarketId = 10, Label = "Yes", TokenId = "t100", CurrentPrice = 1.00m });
market.Outcomes.Add(new MarketOutcome { Id = 101, MarketId = 10, Label = "No", TokenId = "t101", CurrentPrice = 0.00m });
db.Traders.Add(trader);
db.Markets.Add(market);
db.Trades.Add(new Trade
{
Id = 10, TraderId = 1, DbMarketId = 10, MarketOutcomeId = 100,
Side = TradeSide.Buy, Price = 0.40m, Size = 100m, Amount = 40m,
ExecutedAt = DateTime.UtcNow.AddDays(-3)
});
await db.SaveChangesAsync();
}
// Act
using (var db = CreateDbContext(dbName))
{
var pnlEngine = new PositionPnLEngine(db, NullLogger<PositionPnLEngine>.Instance);
await pnlEngine.RecalculateTraderPositionsAsync(1);
}
// Assert: virtual payout 100 × (1.00 0.40) = +60 — NOT 40.
using (var db = CreateDbContext(dbName))
{
var pos = await db.TraderPositions.SingleAsync(p => p.TraderId == 1 && p.MarketOutcomeId == 100);
Assert.Equal(60m, pos.RealizedPnl);
Assert.Equal(0m, pos.SharesHeld);
var analytics = await db.TraderAnalytics.SingleAsync(a => a.TraderId == 1);
Assert.Equal(60m, analytics.OverallPnL);
}
}
/// <summary>
/// Defect 11b: "closed" is NOT "resolved". The Gamma mapper sets
/// IsResolved = closed, so markets that closed for trading but are still
/// awaiting UMA resolution (prices NOT snapped, e.g. 0.70) currently get a
/// virtual payout of 0 → every open position is booked as a total loss
/// days before the real outcome is known. The engine must only settle a
/// position when the outcome is actually decidable (ResolutionOutcome set,
/// or prices snapped to 0/1); otherwise the position stays open with
/// unrealized PnL.
/// </summary>
[Fact]
public async Task RecalculateTraderPositionsAsync_ClosedButUnresolvedMarket_DoesNotBookPrematurePayout()
{
// Arrange
var dbName = Guid.NewGuid().ToString();
using (var db = CreateDbContext(dbName))
{
var trader = new Trader { Id = 1, PlatformUserId = "0x1", DisplayName = "Trader 1" };
var market = new Market
{
Id = 10, PlatformMarketId = 1L, Question = "Q?",
IsResolved = true, // ← buggy mapper sets this for merely CLOSED markets
ResolutionOutcome = null
};
// Prices NOT snapped → UMA has not resolved yet, outcome undecided.
market.Outcomes.Add(new MarketOutcome { Id = 100, MarketId = 10, Label = "Yes", TokenId = "t100", CurrentPrice = 0.70m });
market.Outcomes.Add(new MarketOutcome { Id = 101, MarketId = 10, Label = "No", TokenId = "t101", CurrentPrice = 0.30m });
db.Traders.Add(trader);
db.Markets.Add(market);
db.Trades.Add(new Trade
{
Id = 10, TraderId = 1, DbMarketId = 10, MarketOutcomeId = 100,
Side = TradeSide.Buy, Price = 0.40m, Size = 100m, Amount = 40m,
ExecutedAt = DateTime.UtcNow.AddDays(-3)
});
await db.SaveChangesAsync();
}
// Act
using (var db = CreateDbContext(dbName))
{
var pnlEngine = new PositionPnLEngine(db, NullLogger<PositionPnLEngine>.Instance);
await pnlEngine.RecalculateTraderPositionsAsync(1);
}
// Assert: position must remain OPEN (no premature settlement at payout 0).
using (var db = CreateDbContext(dbName))
{
var pos = await db.TraderPositions.SingleAsync(p => p.TraderId == 1 && p.MarketOutcomeId == 100);
Assert.Equal(100m, pos.SharesHeld);
Assert.Equal(0m, pos.RealizedPnl);
// Unrealized: 100 × (0.70 0.40) = +30
var analytics = await db.TraderAnalytics.SingleAsync(a => a.TraderId == 1);
Assert.Equal(30m, analytics.OverallPnL);
}
}
}
@@ -64,11 +64,33 @@ public class DiscoveryService : IDiscoveryService
var existing = await _traderRepo.GetByPlatformIdAsync(platform, platformUserId, ct);
if (existing != null) return existing.Id;
if (string.IsNullOrEmpty(displayName) || displayName.StartsWith("0x", StringComparison.OrdinalIgnoreCase))
{
var provider = _providers.FirstOrDefault(p => p.Platform == platform);
if (provider != null && provider.IsImplemented)
{
try
{
await _rateLimiter.WaitAsync(platform, ct);
var trades = await provider.GetTraderTradesAsync(platformUserId, 50, ct);
var realName = trades.FirstOrDefault(t => !string.IsNullOrEmpty(t.TransientDisplayName))?.TransientDisplayName;
if (!string.IsNullOrEmpty(realName))
{
displayName = realName;
}
}
catch (Exception ex)
{
_logger.LogWarning(ex, "Failed to fetch real display name for {Wallet} during import", platformUserId);
}
}
}
var trader = new Trader
{
Platform = platform,
PlatformUserId = platformUserId,
DisplayName = string.IsNullOrEmpty(displayName) ? platformUserId[..8] + "..." : displayName,
DisplayName = string.IsNullOrEmpty(displayName) ? (platformUserId.Length > 8 ? platformUserId[..8] + "..." : platformUserId) : displayName,
IsAutoDiscovered = isAutoDiscovered,
CreatedAt = DateTime.UtcNow
};
@@ -87,6 +87,7 @@ public class Trade
/// </summary>
[NotMapped]
public string? TransientWallet { get; set; }
[NotMapped] public string? TransientDisplayName { get; set; }
// ── Navigation ────────────────────────────────────────────────────────
public Trader Trader { get; set; } = null!;
+2 -1
View File
@@ -4,5 +4,6 @@ public enum JobType
{
HistorySync,
TraderAnalysis,
ContextEnrichment
ContextEnrichment,
DeepResync
}
@@ -14,4 +14,5 @@ public interface IJobRepository
Task<BackgroundJob?> GetNextPendingJobAsync(JobType type, CancellationToken ct = default);
Task AddAsync(BackgroundJob job, CancellationToken ct = default);
Task UpdateAsync(BackgroundJob job, CancellationToken ct = default);
Task ResetHungJobsAsync(CancellationToken ct = default);
}
@@ -21,6 +21,9 @@ public interface IPlatformProvider
/// <summary>Fetch recent trades for a specific trader.</summary>
Task<IReadOnlyList<Trade>> GetTraderTradesAsync(string platformUserId, int limit = 50, CancellationToken ct = default);
/// <summary>Fetch all historical trades for a specific trader via pagination.</summary>
Task<IReadOnlyList<Trade>> GetTradesPagedAsync(string platformUserId, int limitPerRequest = 500, CancellationToken ct = default);
/// <summary>Fetch current positions/holdings for a trader.</summary>
Task<IReadOnlyList<TraderPositionInfo>> GetTraderPositionsAsync(string platformUserId, CancellationToken ct = default);
@@ -54,7 +57,8 @@ public record TraderPositionInfo(
decimal Size,
decimal AveragePrice,
decimal CurrentValue,
decimal PnlPercent
decimal PnlPercent,
string? AssetId = null
);
/// <summary>
@@ -52,4 +52,14 @@ public class JobRepository : IJobRepository
_db.BackgroundJobs.Update(job);
await _db.SaveChangesAsync(ct);
}
public async Task ResetHungJobsAsync(CancellationToken ct = default)
{
var cutoff = DateTime.UtcNow.AddMinutes(-15);
await _db.BackgroundJobs
.Where(j => j.Status == JobStatus.InProgress && j.StartedAt < cutoff)
.ExecuteUpdateAsync(s => s
.SetProperty(j => j.Status, JobStatus.Pending)
.SetProperty(j => j.StartedAt, (DateTime?)null), ct);
}
}
@@ -68,7 +68,7 @@ public class TradeRepository : ITradeRepository
t.TransactionHash = StringHelper.Truncate(t.TransactionHash, 66);
}
foreach (var chunk in tradeList.Chunk(1000))
foreach (var chunk in tradeList.Chunk(500))
{
var sb = new System.Text.StringBuilder("INSERT IGNORE INTO Trades (PlatformTradeId, MarketId, AssetId, Outcome, Side, Price, Size, Amount, ExecutedAt, TransactionHash, TraderId, MarketOutcomeId, DbMarketId, Platform, IsContextEnriched) VALUES ");
var parameters = new List<object>();
@@ -99,8 +99,37 @@ public class TradeRepository : ITradeRepository
parameters.Add(t.IsContextEnriched);
}
var rowsInserted = await _db.Database.ExecuteSqlRawAsync(sb.ToString(), parameters.ToArray(), ct);
_logger.LogInformation("Inserted {RowsInserted} trades into the database.", rowsInserted);
int maxRetries = 3;
var backoffs = new[] { 250, 500, 1000 };
for (int retry = 0; retry <= maxRetries; retry++)
{
try
{
var rowsInserted = await _db.Database.ExecuteSqlRawAsync(sb.ToString(), parameters.ToArray(), ct);
_logger.LogInformation("Inserted {RowsInserted} trades into the database.", rowsInserted);
break;
}
catch (Exception ex)
{
var mysqlEx = ex as MySqlConnector.MySqlException ?? ex.InnerException as MySqlConnector.MySqlException;
if (mysqlEx != null && (mysqlEx.Number == 1213 || mysqlEx.Number == 1205))
{
if (retry == maxRetries)
{
_logger.LogError(ex, "Failed to insert {Count} trades after {Retries} retries due to deadlocks.", chunk.Length, maxRetries);
}
else
{
_logger.LogWarning("Deadlock detected during trade insertion. Retrying in {Delay}ms... (Attempt {Attempt}/{Max})", backoffs[retry], retry + 1, maxRetries);
await Task.Delay(backoffs[retry], ct);
}
}
else
{
throw;
}
}
}
}
}
@@ -22,6 +22,9 @@ public class AzuroProvider : IPlatformProvider
public Task<IReadOnlyList<Trade>> GetTraderTradesAsync(string platformUserId, int limit = 50, CancellationToken ct = default)
{ using var _ = PlatformLogContext.Push(PlatformName); _logger.LogWarning("Provider not yet implemented"); return Task.FromResult<IReadOnlyList<Trade>>(Array.Empty<Trade>()); }
public Task<IReadOnlyList<Trade>> GetTradesPagedAsync(string platformUserId, int limitPerRequest = 500, CancellationToken ct = default)
{ using var _ = PlatformLogContext.Push(PlatformName); _logger.LogWarning("Provider not yet implemented"); return Task.FromResult<IReadOnlyList<Trade>>(Array.Empty<Trade>()); }
public Task<IReadOnlyList<TraderPositionInfo>> GetTraderPositionsAsync(string platformUserId, CancellationToken ct = default)
{ using var _ = PlatformLogContext.Push(PlatformName); _logger.LogWarning("Provider not yet implemented"); return Task.FromResult<IReadOnlyList<TraderPositionInfo>>(Array.Empty<TraderPositionInfo>()); }
@@ -25,6 +25,11 @@ public class LimitlessProvider : IPlatformProvider
_logger = logger;
}
public Task<IReadOnlyList<Trade>> GetTradesPagedAsync(string platformUserId, int limitPerRequest = 500, CancellationToken ct = default)
{
throw new NotImplementedException();
}
public async Task<IReadOnlyList<Trade>> GetTraderTradesAsync(string platformUserId, int limit = 50, CancellationToken ct = default)
{
using var _ = PlatformLogContext.Push(PlatformName);
@@ -46,6 +46,39 @@ public class PolymarketApiClient
return await ExecuteWithRetryAsync<List<PolymarketTradeResponse>>(_client, url, "Data", ct) ?? [];
}
public async Task<List<PolymarketTradeResponse>> GetTradesPagedAsync(string walletAddress, int limit = 500, CancellationToken ct = default)
{
var allTrades = new List<PolymarketTradeResponse>();
long? endTimestamp = null;
while (true)
{
var url = $"/activity?user={walletAddress}&limit={limit}";
if (endTimestamp.HasValue)
{
url += $"&end={endTimestamp.Value}";
}
var batch = await ExecuteWithRetryAsync<List<PolymarketTradeResponse>>(_client, url, "Data", ct);
if (batch == null || batch.Count == 0)
{
break;
}
allTrades.AddRange(batch);
if (batch.Count < limit)
{
break;
}
var oldestTimestamp = batch.Min(t => t.Timestamp);
endTimestamp = oldestTimestamp - 1;
}
return allTrades;
}
public async Task<List<PolymarketTradeResponse>> GetMarketTradesAsync(string conditionId, int limit = 1000, int offset = 0, CancellationToken ct = default)
{
var url = $"/trades?condition_id={conditionId}&limit={limit}&offset={offset}";
@@ -59,10 +59,20 @@ public class PolymarketTradeResponse
[JsonConverter(typeof(FlexibleDoubleConverter))]
public double Size { get; set; }
[JsonPropertyName("usdcSize")]
[JsonConverter(typeof(FlexibleDoubleConverter))]
public double UsdcSize { get; set; }
[JsonPropertyName("price")]
[JsonConverter(typeof(FlexibleDoubleConverter))]
public double Price { get; set; }
[JsonPropertyName("outcomeIndex")]
public int? OutcomeIndex { get; set; }
[JsonPropertyName("name")] public string? Name { get; set; }
[JsonPropertyName("pseudonym")] public string? Pseudonym { get; set; }
[JsonPropertyName("outcome")] public string Outcome { get; set; } = "";
[JsonPropertyName("timestamp")]
@@ -137,7 +147,7 @@ public class GammaMarketResponse
[JsonPropertyName("closed")] public bool Closed { get; set; }
[JsonPropertyName("active")] public bool Active { get; set; }
[JsonPropertyName("resolved")] public bool Resolved { get; set; }
[JsonPropertyName("resolution_outcome")] public string? ResolutionOutcome { get; set; }
[JsonPropertyName("umaResolutionStatus")] public string? UmaResolutionStatus { get; set; }
[JsonPropertyName("negRisk")] public bool NegRisk { get; set; }
[JsonPropertyName("closedTime")] public string? ClosedTime { get; set; }
[JsonPropertyName("takerFee")] [JsonConverter(typeof(FlexibleDoubleConverter))] public double TakerFee { get; set; }
@@ -56,13 +56,50 @@ public class PolymarketProvider : IPlatformProvider
TransactionHash = r.TransactionHash?.ToLowerInvariant(),
TraderId = 0,
TransientWallet = wallet,
TransientDisplayName = !string.IsNullOrEmpty(r.Name) ? r.Name : r.Pseudonym
};
}).ToList();
return mappedTrades.GroupBy(t => t.PlatformTradeId, StringComparer.OrdinalIgnoreCase).Select(g => g.First()).ToList();
}
public async Task<IReadOnlyList<Trade>> GetTradesPagedAsync(string platformUserId, int limitPerRequest = 500, CancellationToken ct = default)
{
using var _ = PlatformLogContext.Push(PlatformName);
_logger.LogDebug("Fetching all paged trades for {Wallet}", platformUserId);
var raw = await _api.GetTradesPagedAsync(platformUserId, limitPerRequest, ct);
_logger.LogInformation("Fetched {Count} trades total for {Wallet}", raw.Count, platformUserId);
var mappedTrades = raw.Select(r =>
{
var wallet = !string.IsNullOrEmpty(r.User) ? r.User :
!string.IsNullOrEmpty(r.ProxyWallet) ? r.ProxyWallet :
platformUserId;
var side = MapTradeSide(r);
var sideStr = side.ToString().ToUpperInvariant();
return new Trade
{
Platform = PlatformType.Polymarket,
PlatformTradeId = string.IsNullOrEmpty(r.TransactionHash)
? $"{r.Timestamp}_{wallet}_{r.Asset}_{sideStr}"
: $"{r.TransactionHash.ToLowerInvariant()}_{wallet}_{r.Asset}_{sideStr}",
MarketId = r.ConditionId ?? "",
AssetId = r.Asset ?? "",
Outcome = r.Outcome ?? "",
Side = side,
Price = (decimal)r.Price,
Size = (decimal)r.Size,
Amount = (decimal)(r.Price * r.Size),
ExecutedAt = DateTimeOffset.FromUnixTimeSeconds(r.Timestamp).UtcDateTime,
TransactionHash = r.TransactionHash?.ToLowerInvariant(),
TraderId = 0,
TransientWallet = wallet,
TransientDisplayName = !string.IsNullOrEmpty(r.Name) ? r.Name : r.Pseudonym
};
}).ToList();
return mappedTrades.GroupBy(t => t.PlatformTradeId, StringComparer.OrdinalIgnoreCase).Select(g => g.First()).ToList();
}
public async Task<IReadOnlyList<Trade>> GetMarketTradesAsync(string platformMarketId, int limit = 1000, CancellationToken ct = default)
{
var raw = await _api.GetMarketTradesAsync(platformMarketId, limit, 0, ct);
@@ -90,6 +127,7 @@ public class PolymarketProvider : IPlatformProvider
TransactionHash = r.TransactionHash,
TraderId = 0,
TransientWallet = wallet,
TransientDisplayName = !string.IsNullOrEmpty(r.Name) ? r.Name : r.Pseudonym
};
}).ToList();
@@ -106,7 +144,8 @@ public class PolymarketProvider : IPlatformProvider
return raw.Select(r => new TraderPositionInfo(
platformUserId, r.Market, r.Question, r.Outcome,
(decimal)r.Size, (decimal)r.AvgPrice,
(decimal)r.CurrentValue, (decimal)r.PercentPnl
(decimal)r.CurrentValue, (decimal)r.PercentPnl,
r.AssetId
)).ToList();
}
@@ -300,8 +339,6 @@ public class PolymarketProvider : IPlatformProvider
EndDate = DateTime.TryParse(raw.EndDate ?? raw.EndDateIso, out var med) ? med : null,
CreatedAt = DateTime.TryParse(raw.CreatedAt, out var mcd) ? mcd : DateTime.UtcNow,
DbCreatedAt = DateTime.UtcNow,
IsResolved = raw.Resolved || raw.Closed,
ResolutionOutcome = raw.ResolutionOutcome,
LastUpdatedAt = DateTime.UtcNow,
FeeRateBps = (decimal)(raw.TakerFee * 10000),
IsNegRisk = raw.NegRisk,
@@ -313,6 +350,11 @@ public class PolymarketProvider : IPlatformProvider
var outcomePrices = ParseJsonStringArray(raw.OutcomePrices);
var tokenIds = ParseJsonStringArray(raw.ClobTokenIds);
bool pricesSnapped = false;
bool hasHighPrice = false;
bool allSnapped = outcomePrices.Count > 0;
string? snappedWinnerLabel = null;
for (int i = 0; i < outcomeLabels.Count; i++)
{
decimal price = 0;
@@ -320,8 +362,6 @@ public class PolymarketProvider : IPlatformProvider
decimal.TryParse(outcomePrices[i], System.Globalization.NumberStyles.Any,
System.Globalization.CultureInfo.InvariantCulture, out price);
string tokenId = i < tokenIds.Count ? tokenIds[i] : "";
var label = outcomeLabels[i];
if ((label.Equals("Yes", StringComparison.OrdinalIgnoreCase) || label.Equals("No", StringComparison.OrdinalIgnoreCase))
&& !string.IsNullOrEmpty(raw.GroupItemTitle))
@@ -329,6 +369,21 @@ public class PolymarketProvider : IPlatformProvider
label = $"{raw.GroupItemTitle} - {label}";
}
if (price <= 0.02m || price >= 0.98m)
{
if (price >= 0.98m)
{
hasHighPrice = true;
snappedWinnerLabel = label;
}
}
else
{
allSnapped = false;
}
string tokenId = i < tokenIds.Count ? tokenIds[i] : "";
market.Outcomes.Add(new MarketOutcome
{
Label = label,
@@ -338,6 +393,11 @@ public class PolymarketProvider : IPlatformProvider
});
}
pricesSnapped = allSnapped && hasHighPrice;
market.IsResolved = raw.UmaResolutionStatus == "resolved" || (raw.Closed && pricesSnapped);
market.ResolutionOutcome = market.IsResolved ? snappedWinnerLabel : null;
return market;
}
@@ -177,16 +177,13 @@ public class PositionPnLEngine : IPositionPnLEngine
break;
case TradeSide.Redeem:
var market = trade.MarketOutcome.Market;
var isResolved = market?.IsResolved ?? false;
var resolutionOutcome = market?.ResolutionOutcome;
var isWinner = isResolved && Predictalytics.Domain.Helpers.MarketOutcomeHelper.IsWinningOutcome(trade.MarketOutcome, resolutionOutcome);
var payout = isWinner ? 1.00m : 0.00m;
currentBalance += (pos.SharesHeld * payout);
pos.RealizedPnl += pos.SharesHeld * (payout - pos.AvgCost);
pos.SharesHeld = 0;
pos.AvgCost = 0;
if (TryDeterminePayout(trade.MarketOutcome, out var redeemPayout))
{
currentBalance += (pos.SharesHeld * redeemPayout);
pos.RealizedPnl += pos.SharesHeld * (redeemPayout - pos.AvgCost);
pos.SharesHeld = 0;
pos.AvgCost = 0;
}
break;
case TradeSide.Split:
@@ -241,13 +238,9 @@ public class PositionPnLEngine : IPositionPnLEngine
{
if (pos.SharesHeld > 0 && pos.MarketOutcome?.Market != null)
{
var market = pos.MarketOutcome.Market;
if (market.IsResolved)
if (TryDeterminePayout(pos.MarketOutcome, out var virtualPayout))
{
var isWinner = Predictalytics.Domain.Helpers.MarketOutcomeHelper.IsWinningOutcome(pos.MarketOutcome, market.ResolutionOutcome);
var payout = isWinner ? 1.00m : 0.00m;
var virtualPnlDelta = pos.SharesHeld * (payout - pos.AvgCost);
var virtualPnlDelta = pos.SharesHeld * (virtualPayout - pos.AvgCost);
pos.RealizedPnl += virtualPnlDelta;
pos.SharesHeld = 0;
pos.AvgCost = 0;
@@ -553,4 +546,25 @@ public class PositionPnLEngine : IPositionPnLEngine
return result;
}
private bool TryDeterminePayout(MarketOutcome outcome, out decimal payout)
{
payout = 0m;
var market = outcome.Market;
if (market == null || !market.IsResolved) return false;
if (!string.IsNullOrWhiteSpace(market.ResolutionOutcome))
{
payout = Predictalytics.Domain.Helpers.MarketOutcomeHelper.IsWinningOutcome(outcome, market.ResolutionOutcome) ? 1.00m : 0.00m;
return true;
}
if (market.Outcomes != null && market.Outcomes.Any(o => o.CurrentPrice >= 0.98m))
{
payout = outcome.CurrentPrice >= 0.98m ? 1.00m : 0.00m;
return true;
}
return false;
}
}
@@ -64,10 +64,16 @@ public class PollingWorker : BackgroundService
await rateLimiter.WaitAsync(trader.Platform, stoppingToken);
var trades = await provider.GetTraderTradesAsync(trader.PlatformUserId, 100, stoppingToken);
// ── Filter: skip trades with empty PlatformTradeId ──
var validTrades = trades
.Where(t => !string.IsNullOrWhiteSpace(t.PlatformTradeId))
.ToList();
var updatedName = validTrades.FirstOrDefault(t => !string.IsNullOrEmpty(t.TransientDisplayName))?.TransientDisplayName;
if (!string.IsNullOrEmpty(updatedName) && !string.Equals(trader.DisplayName, updatedName, StringComparison.OrdinalIgnoreCase))
{
trader.DisplayName = updatedName;
await traderRepo.UpdateAsync(trader, stoppingToken);
}
if (validTrades.Count < trades.Count)
{
@@ -147,6 +153,11 @@ public class PollingWorker : BackgroundService
trader.LastPolledAt = DateTime.UtcNow;
await traderRepo.UpdateAsync(trader, stoppingToken);
}
catch (OperationCanceledException) when (stoppingToken.IsCancellationRequested)
{
_logger.LogInformation("Cancellation requested during polling, stopping batch.");
break;
}
catch (Exception ex)
{
_logger.LogError(ex, "Error polling trader {Trader} on {Platform}",
@@ -107,6 +107,11 @@ public class TradeContextEnrichmentWorker : BackgroundService
updatedCount++;
}
}
catch (OperationCanceledException) when (stoppingToken.IsCancellationRequested)
{
_logger.LogInformation("Cancellation requested during enrichment, stopping batch.");
break;
}
catch (Exception ex)
{
_logger.LogError(ex, "Failed to enrich asset {AssetId}", assetId);
@@ -31,6 +31,13 @@ public class TradeHistoryWorker : BackgroundService
protected override async Task ExecuteAsync(CancellationToken stoppingToken)
{
_logger.LogInformation("📜 TradeHistoryWorker started (update cooldown: {Hours}h)", CooldownHours);
using (var scope = _services.CreateScope())
{
var jobRepo = scope.ServiceProvider.GetRequiredService<IJobRepository>();
await jobRepo.ResetHungJobsAsync(stoppingToken);
}
await Task.Delay(15000, stoppingToken);
while (!stoppingToken.IsCancellationRequested)
@@ -43,7 +50,11 @@ public class TradeHistoryWorker : BackgroundService
using (var scope = _services.CreateScope())
{
var jobRepo = scope.ServiceProvider.GetRequiredService<IJobRepository>();
activeJob = await jobRepo.GetNextPendingJobAsync(Predictalytics.Domain.Enums.JobType.HistorySync, stoppingToken);
activeJob = await jobRepo.GetNextPendingJobAsync(Predictalytics.Domain.Enums.JobType.DeepResync, stoppingToken);
if (activeJob == null)
{
activeJob = await jobRepo.GetNextPendingJobAsync(Predictalytics.Domain.Enums.JobType.HistorySync, stoppingToken);
}
var repo = scope.ServiceProvider.GetRequiredService<ITraderRepository>();
@@ -109,12 +120,35 @@ public class TradeHistoryWorker : BackgroundService
using var platformCtx = PlatformLogContext.Push(provider.PlatformName);
await rateLimiter.WaitAsync(trader.Platform, ct);
bool isInitial = !trader.IsInitialImportComplete;
_logger.LogInformation("{Trader}: Starting {Type} sync", trader.DisplayName, isInitial ? "INITIAL FULL" : "INCREMENTAL");
bool isDeepResync = activeJob != null && activeJob.JobType == Predictalytics.Domain.Enums.JobType.DeepResync;
bool isInitial = !trader.IsInitialImportComplete || isDeepResync;
_logger.LogInformation("{Trader}: Starting {Type} sync", trader.DisplayName, isDeepResync ? "DEEP RESYNC" : (isInitial ? "INITIAL FULL" : "INCREMENTAL"));
var fetchedTrades = await provider.GetTraderTradesAsync(trader.PlatformUserId, TradesPerFetch, ct);
if (isDeepResync)
{
var db = scope.ServiceProvider.GetRequiredService<Predictalytics.Infrastructure.Data.AppDbContext>();
await Microsoft.EntityFrameworkCore.RelationalDatabaseFacadeExtensions.ExecuteSqlRawAsync(db.Database, "DELETE FROM Trades WHERE TraderId = {0} AND PlatformTradeId LIKE 'COMPACT_%'", t.Id);
await Microsoft.EntityFrameworkCore.RelationalDatabaseFacadeExtensions.ExecuteSqlRawAsync(db.Database, "DELETE FROM TraderPositions WHERE TraderId = {0}", t.Id);
}
IReadOnlyList<Domain.Entities.Trade> fetchedTrades;
if (isDeepResync)
{
fetchedTrades = await provider.GetTradesPagedAsync(trader.PlatformUserId, 500, ct);
}
else
{
fetchedTrades = await provider.GetTraderTradesAsync(trader.PlatformUserId, TradesPerFetch, ct);
}
var validTrades = fetchedTrades.Where(tr => !string.IsNullOrWhiteSpace(tr.PlatformTradeId)).ToList();
var updatedName = validTrades.FirstOrDefault(t => !string.IsNullOrEmpty(t.TransientDisplayName))?.TransientDisplayName;
if (!string.IsNullOrEmpty(updatedName) && !string.Equals(trader.DisplayName, updatedName, StringComparison.OrdinalIgnoreCase))
{
trader.DisplayName = updatedName;
await traderRepo.UpdateAsync(trader, ct);
}
var fetchedTradeIds = validTrades.Select(tr => tr.PlatformTradeId).ToList();
var knownTradeIds = await tradeRepo.GetKnownPlatformTradeIdsAsync(trader.Platform, trader.Id, fetchedTradeIds, ct);
@@ -230,6 +264,7 @@ public class TradeHistoryWorker : BackgroundService
trader.IsInitialImportComplete = true;
trader.LastTradesUpdatedAt = DateTime.UtcNow;
trader.LastPolledAt = DateTime.UtcNow;
if (isDeepResync) trader.LastAnalyzedAt = null;
await traderRepo.UpdateAsync(trader, ct);
if (activeJob != null && activeJob.TraderId == trader.Id)
@@ -88,10 +88,17 @@ public class TradeReconciliationWorker : BackgroundService
var newEvents = new List<Predictalytics.Domain.Entities.Event>();
foreach (var marketId in missingMarketIds)
{
var market = await polyProvider.GetMarketAsync(marketId, ct);
if (market != null && market.Event != null)
try
{
newEvents.Add(market.Event);
var market = await polyProvider.GetMarketAsync(marketId, ct);
if (market != null && market.Event != null)
{
newEvents.Add(market.Event);
}
}
catch (Exception ex)
{
_logger.LogError(ex, "Failed to fetch market {MarketId} during reconciliation", marketId);
}
}
if (newEvents.Count > 0)
@@ -108,15 +115,27 @@ public class TradeReconciliationWorker : BackgroundService
.Distinct()
.ToListAsync(ct);
reconciledCount = await Microsoft.EntityFrameworkCore.RelationalDatabaseFacadeExtensions.ExecuteSqlRawAsync(db.Database, @"
UPDATE Trades t
INNER JOIN MarketOutcomes o ON t.AssetId = o.TokenId
INNER JOIN Markets m ON o.MarketId = m.Id
SET t.MarketOutcomeId = o.Id,
t.Outcome = o.Label,
t.DbMarketId = m.Id
WHERE t.MarketOutcomeId IS NULL AND t.AssetId != '';
", ct);
int totalReconciled = 0;
int batchAffected;
do
{
batchAffected = await Microsoft.EntityFrameworkCore.RelationalDatabaseFacadeExtensions.ExecuteSqlRawAsync(db.Database, @"
UPDATE Trades t
JOIN (
SELECT t2.Id, o.Id AS OutcomeId, o.Label, m.Id AS MarketDbId
FROM Trades t2
JOIN MarketOutcomes o ON t2.AssetId = o.TokenId
JOIN Markets m ON o.MarketId = m.Id
WHERE t2.MarketOutcomeId IS NULL AND t2.AssetId != ''
LIMIT 5000
) x ON t.Id = x.Id
SET t.MarketOutcomeId = x.OutcomeId, t.Outcome = x.Label, t.DbMarketId = x.MarketDbId;
", ct);
totalReconciled += batchAffected;
if (batchAffected > 0) await Task.Delay(100, ct);
} while (batchAffected > 0);
reconciledCount = totalReconciled;
if (reconciledCount > 0 && pairsToReset.Any())
{
@@ -164,6 +183,10 @@ public class TradeReconciliationWorker : BackgroundService
.ExecuteUpdateAsync(s => s.SetProperty(p => p.LastAnalyzedAt, (DateTime?)null), ct);
}
}
catch (OperationCanceledException) when (ct.IsCancellationRequested)
{
_logger.LogInformation("Cancellation requested during reconciliation, stopping batch.");
}
catch (Exception ex)
{
_logger.LogError(ex, "Error executing bulk reconciliation SQL");
@@ -44,6 +44,7 @@ public class TradeRetentionWorker : BackgroundService
{
await RunOptimizationAsync(stoppingToken);
}
catch (OperationCanceledException) { break; }
catch (Exception ex)
{
_logger.LogError(ex, "Error occurred executing TradeRetentionWorker cycle.");
@@ -61,6 +62,13 @@ public class TradeRetentionWorker : BackgroundService
var db = scope.ServiceProvider.GetRequiredService<AppDbContext>();
// Load configuration values
bool isEnabled = _config.GetValue("RetentionSettings:Enabled", true);
if (!isEnabled)
{
_logger.LogInformation("🧹 TradeRetentionWorker: Retention is disabled in configuration. Skipping optimization.");
return;
}
var retentionDays = _config.GetValue("RetentionSettings:RetentionDays", 90);
var compactionDays = _config.GetValue("RetentionSettings:CompactionDays", 14);
@@ -88,6 +88,7 @@ public class TraderAnalyticsWorker : BackgroundService
foreach (var id in traderIds)
{
if (ct.IsCancellationRequested) break;
try
{
using var traderScope = _services.CreateScope();
@@ -149,6 +150,11 @@ public class TraderAnalyticsWorker : BackgroundService
await updateJobRepo.UpdateAsync(activeJob, ct);
}
}
catch (OperationCanceledException) when (ct.IsCancellationRequested)
{
_logger.LogInformation("Cancellation requested during analysis, stopping batch.");
break;
}
catch (Exception ex)
{
_logger.LogError(ex, "Error recalculating positions/PnL for trader {TraderId}", id);